Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link section for Cover Image Block Settings #12684

Open
CalumChilds opened this issue Dec 7, 2018 · 66 comments
Open

Add a link section for Cover Image Block Settings #12684

CalumChilds opened this issue Dec 7, 2018 · 66 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Media Anything that impacts the experience of managing media Needs Accessibility Feedback Need input from accessibility [Type] Enhancement A suggestion for improvement.

Comments

@CalumChilds
Copy link

CalumChilds commented Dec 7, 2018

Is your feature request related to a problem? Please describe.
I want to link a cover image block to a particular page, which I can't do without delving into the code.

Describe the solution you'd like
A "Link" section in the Block settings sidebar (see below)
image

Describe alternatives you've considered
For now, I will use HTML to link it to the page I want. But most people using this new editor have probably never heard of HTML, let alone coded in it.
(Edit: I've just tried to do this and it says that the block contains "unexpected content" - see below:)
image
This is the code I entered:
image

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Dec 7, 2018
@jaclyntan
Copy link

Along with link options I'd also like to add headings and paragraphs within the block.
I know a section block was being explored but I'd like to see more options in the cover block so it's more flexible. Thank you!

@CalumChilds
Copy link
Author

@jaclyntan This has been done in Gutenberg 5.3, where you can now add blocks within the Cover Block.

@foosantos
Copy link
Member

@affeldt28
Copy link

I would like to see the feature implemented, its a bit annoying to always manually edit as html and add links.
Sad that since 2018 nobody done it. i think it shouldn't be very difficult to do.

@boomtemp123
Copy link

Same here, being able to link these is a good idea and something that you'd expect to be one of the basic functions. Kioken blocks allows this on it's image block.

@boomtemp123
Copy link

@phpbits
Copy link
Contributor

phpbits commented Feb 10, 2020

Added Link toolbar to EditorsKit plugin for the following blocks. I hope this could be of huge help. Thanks!

  • Cover Block
  • Group Block
  • Column Block

Options available are:

  • Link to New Tab
  • NoFollow rel attribute
  • Sponsored rel attribute
  • Hover animation option

Here's the preview and EditorsKit is available for free on the plugin directory.

Add a link section for Cover Image Block Settings

@paaljoachim paaljoachim added the Needs Dev Ready for, and needs developer efforts label Jun 2, 2020
@paaljoachim
Copy link
Contributor

We need a developer to add this into the Cover Block similar to how Media & Text Block now has a link.

Media & Text Block has in the toolbar a link icon to the left of the Replace button.
Screen Shot 2020-06-02 at 17 28 16

For the Cover Block one would do something similar. Adding a link to the left of Replace button.
Like this mockup:
Cover-Block-Link-wireframe

@CalumChilds
Copy link
Author

CalumChilds commented Jun 2, 2020 via email

@tripledm
Copy link

tripledm commented Jun 2, 2020

As mentioned earlier in this thread, there is already a plugin (EditorsKit) with this feature embedded. We have a working prototype, all someone needs to do is add it to the Gutenberg code.

Sadly EditorsKit works on one site but the others I manage not as just getting a blank screen and timeout when I try edit a post during tests. Anyway, not the forum for that topic as it's a conflict somewhere but to bump your request up with my response.

The issue was raised (this thread) 1.5 years ago and considering the importance of this I would only hope it's added to core sooner rather than later.

@paaljoachim paaljoachim added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jun 30, 2020
@kjellr
Copy link
Contributor

kjellr commented Aug 17, 2020

Just want to add my voice here to say that the native ability to link an entire Group or Cover block to a single URL would definitely come in handy for a variety of layouts.

Here's an example pattern that features two "Cards". Ideally, these entire cards would be clickable, but there's no way in Gutenberg today to make that happen.

Screen Shot 2020-08-17 at 1 00 08 PM

(design via @beafialho)

@CalumChilds
Copy link
Author

CalumChilds commented Aug 17, 2020 via email

@enriquesanchez enriquesanchez added the Needs Accessibility Feedback Need input from accessibility label Sep 10, 2020
@cguntur
Copy link

cguntur commented Sep 23, 2020

I can take up this one.

@ZebulanStanphill
Copy link
Member

I know links can often eat semantics when used improperly, so I think we ought to be careful about adding something like this. It's possible that this may be an accessibility anti-pattern that we should avoid at all costs... or it could be completely fine. I'm not really sure. Pinging @afercia from the accessibility team to check this out and give feedback.

@afercia
Copy link
Contributor

afercia commented Sep 24, 2020

Cover blocks (and group blocks, and possibly other blocks) can already contain links:

Screenshot 2020-09-24 at 10 22 12

When a "block-level link" is added to wrap the block, there shouldn't be other links within the block content to avoid nested links. So this feature should make sure to:

  • automatically remove links within the content, if any
  • remove from the UI of any block within the cover/group the ability do add links into the content

@afercia
Copy link
Contributor

afercia commented Sep 24, 2020

I know links can often eat semantics when used improperly,

Yep, it really depends on what's inside the linked block. Expanding my previous comment: what if inside the block there's, say, an input field, or a button, or any other interactive element? A link should contain only non-interactive elements. The implementation should make sure to avoid nested interactive elements. At a first glance, this appears to be a bit complicated especially with existing content: should the block content be "cleared" of any interactive element when the block gets linked?

@CalumChilds
Copy link
Author

CalumChilds commented Sep 24, 2020 via email

@afercia
Copy link
Contributor

afercia commented Sep 24, 2020

I don't think anyone putting a link around the Cover block would be having any input fields or buttons inside it,

I don't think we can trust users this way 🙂 Valid, semantic, accessible markup should be enforced via code.

@ZebulanStanphill
Copy link
Member

The disable-link-control-on-nested blocks idea sounds very similar to the issue where sometimes we want to disable the block alignment controls for blocks when they are nested inside another block with a layout/style that doesn't support those alignments. Perhaps the solution to both problems is the same... but I'm not sure what that solution is.

@cguntur
Copy link

cguntur commented Sep 28, 2020

I might need some guidance on this one.

@paaljoachim
Copy link
Contributor

Hi Chandrika @cguntur

After you get a bit going you can then ask questions that arise directly in the core-editor Slack channel, and let people know that are you are new and working on figuring out ......
You can also ask questions during the Open Floor of a core editor chat.
There are many people that can give help.

@cguntur
Copy link

cguntur commented Sep 29, 2020

@paaljoachim Ok, I will give it a try. Thank you for the help.

@talldan
Copy link
Contributor

talldan commented Sep 30, 2020

Not that I disagree with the intent of preventing invalid markup, but this feature sounds like a bit of a minefield in terms of implementation.

Any feature would have to handle various situations:

  • Links already exist on inner blocks when the user wants to apply the cover block link (is the cover block link interface disabled in this situation? Or alternatively inner block links are stripped when the cover links is applied? What about blocks that represent entire links (e.g. buttons), how are they handled? Third-party blocks?)
  • The user applies the outer link and then tries to add inner links (is the inner block link interface disabled in this situation? And then what about button blocks and third party blocks?)
  • Detection of inner links would have to work for any level of block nesting.

I also think it's going to be hard to relay to the user what the problem is that's preventing the addition of links.

Feels like this particular problem needs some design input more than anything, so I'll apply that label.

@gOuTM
Copy link

gOuTM commented Sep 15, 2022

Hej!

Any chance to have this useful feature as a core functionality?

@bradhogan
Copy link

Any updates on this? This should really be added at this point. We need to be able to link rows, columns, groups and cover blocks.

@petko
Copy link

petko commented Nov 2, 2022

We definitely need this soon!

@gilsonviana
Copy link

+1 ✨

@mrfoxtalbot
Copy link

There is a related conversation (but discussing the columns block) on this issue #45959

@clairedornic
Copy link

+1 for this, please !

@gaswirth
Copy link

+1!!!

@bradhogan
Copy link

Any updates on this? Cover and Group/Row/Column blocks should have an option to link.

@LeoBoudet
Copy link

+1 here

@Gustavo-Hilario
Copy link

Gustavo-Hilario commented May 7, 2023

Chatted with a user recently who wanted the Cover block to work as a link when added inside the Query Loop block. When added inside the Query Loop, we can use the Featured image as the cover image, but it would be awesome to have that image clickable too.

@sc0ttkclark
Copy link

I'd love to see this implemented though I understand the limitations. Most of the use-cases I have needed this for involve Image blocks that would normally be a link but then I wanted to add text over the image and it turns it into a Cover block. Then only the text can be linked at that point and the rest of the click area of the cover image can't be used.

@passatgt
Copy link

Want to add a CSS solution until this feature is available. Add the class-name "full-link" to your cover image block under the advanced tab:

image

Add a link to any of the content inside the cover image. This can be an empty paragraph with a space too for example, you just need a link inside the block. Then add the following extra CSS under Styles / ... / Additional CSS:

image
.full-link a:after {
display:block;
position:absolute;
left:0;
top:0;
width:100%;
height:100%;
content:'';
}

Now your click area is expanded to the whole block. Class can be used on any other block too.

@tnchuntic
Copy link

Any updates on this "add link functionality to Cover block"?

@AceMedia
Copy link

AceMedia commented Sep 8, 2023

I'd love to see this implemented.

@passatgt
Copy link

passatgt commented Sep 8, 2023

Another solution is to create an extra style for the cover block. Add this code to your functions.php:

add_action( 'init', function(){
    register_block_style( 'core/cover', array(
        'name'         => 'full-link',
        'label'        => 'Link',
        'inline_style' => '.wp-block-cover.is-style-full-link a:after {
            display:block;
            position:absolute;
            left:0;
            top:0;
            width:100%;
            height:100%;
            content:"";
        }'
    ));
});

This will create a new style for the cover image block called Link, and you can select it in the styles tab:

image

And after this, it works the same way as my css solution above, just add a link inside the cover image to any element and it will make the whole block clickable.

@ACAwebbuilder
Copy link

ACAwebbuilder commented Sep 17, 2023

Hi passatgt!

Thanks for this idea. I just tried it and don't have the Styles section set-up like in your image. I pasted the code in my Child theme's Function.php.

It is my first time editing that file...is there a specific place I am supposed to paste?

@passatgt
Copy link

Hi passatgt!

Thanks for this idea. I just tried it and don't have the Styles section set-up like in your image. I pasted the code in my Child theme's Function.php.

It is my first time editing that file...is there a specific place I am supposed to paste?

Might be a theme compatibility issue? I tried it with the default twentytwenty-three theme and works fine in the functions.php.

@davipontesblog
Copy link

Similar request from WordPress.com customers as well.

@Gustavo-Hilario
Copy link

+1

1 similar comment
@masperber
Copy link

+1

@dolgelukkig
Copy link

  • 1

@chekle
Copy link

chekle commented Mar 14, 2024

+1

1 similar comment
@gregdotelphotography
Copy link

+1

@DeanE1
Copy link

DeanE1 commented Mar 26, 2024

How has this not been implemented into core yet? I thought I had this problem licked adding an image with a text overlay just to find it converts my block to a cover image which does not allow the image to be clickable. Please add this seemingly basic function to core.

@smetsson
Copy link

smetsson commented Apr 5, 2024

  • 1 👍

@iamtakashi
Copy link

+1. It has been said before, but the cover block is useful in a query loop to show featured images with titles etc. It's a very common pattern for the thumbnail(featured image) to be clickable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Media Anything that impacts the experience of managing media Needs Accessibility Feedback Need input from accessibility [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests