New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a link section for Cover Image Block Settings #12684
Comments
Along with link options I'd also like to add headings and paragraphs within the block. |
@jaclyntan This has been done in Gutenberg 5.3, where you can now add blocks within the Cover Block. |
Someone just asked about it here. |
I would like to see the feature implemented, its a bit annoying to always manually edit as html and add links. |
Same here, being able to link these is a good idea and something that you'd expect to be one of the basic functions. Kioken blocks allows this on it's image block. |
Similar issue raised here: https://wordpress.org/support/topic/no-way-to-link-a-cover-block/ |
Added Link toolbar to EditorsKit plugin for the following blocks. I hope this could be of huge help. Thanks!
Options available are:
Here's the preview and EditorsKit is available for free on the plugin directory. |
As mentioned earlier in this thread, there is already a plugin (EditorsKit) with this feature embedded. We have a working prototype, all someone needs to do is add it to the Gutenberg code.
|
Sadly EditorsKit works on one site but the others I manage not as just getting a blank screen and timeout when I try edit a post during tests. Anyway, not the forum for that topic as it's a conflict somewhere but to bump your request up with my response. The issue was raised (this thread) 1.5 years ago and considering the importance of this I would only hope it's added to core sooner rather than later. |
Just want to add my voice here to say that the native ability to link an entire Group or Cover block to a single URL would definitely come in handy for a variety of layouts. Here's an example pattern that features two "Cards". Ideally, these entire cards would be clickable, but there's no way in Gutenberg today to make that happen. (design via @beafialho) |
I agree. Maybe we could get this feature in for WordPress 5.6?
…Sent from my iPod
On 17 Aug 2020, at 18:02, Kjell Reigstad <notifications@github.com<mailto:notifications@github.com>> wrote:
Just want to add my voice here to say that the native ability to link an entire Group or Cover block to a single URL would definitely come in handy for a variety of layouts.
Here's an example pattern that features two "Cards". Ideally, these entire cards would be clickable, but there's no way in Gutenberg today to make that happen.
[Screen Shot 2020-08-17 at 1 00 08 PM]<https://user-images.githubusercontent.com/1202812/90422960-a749e280-e089-11ea-9232-cfd32b793e9b.png>
(design via @beafialho<https://github.com/beafialho>)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#12684 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGBR2AJXXPXQB2T5NL4Y4ODSBFPBXANCNFSM4GJDD7VA>.
|
I can take up this one. |
I know links can often eat semantics when used improperly, so I think we ought to be careful about adding something like this. It's possible that this may be an accessibility anti-pattern that we should avoid at all costs... or it could be completely fine. I'm not really sure. Pinging @afercia from the accessibility team to check this out and give feedback. |
Cover blocks (and group blocks, and possibly other blocks) can already contain links: When a "block-level link" is added to wrap the block, there shouldn't be other links within the block content to avoid nested links. So this feature should make sure to:
|
Yep, it really depends on what's inside the linked block. Expanding my previous comment: what if inside the block there's, say, an input field, or a button, or any other interactive element? A link should contain only non-interactive elements. The implementation should make sure to avoid nested interactive elements. At a first glance, this appears to be a bit complicated especially with existing content: should the block content be "cleared" of any interactive element when the block gets linked? |
an input field, or a button
I don't think anyone putting a link around the Cover block would be having any input fields or buttons inside it, as this would defeat the purpose of a link surrounding the Cover block.
…________________________________
From: Andrea Fercia <notifications@github.com>
Sent: 24 September 2020 10:43
To: WordPress/gutenberg <gutenberg@noreply.github.com>
Cc: Calum Childs <calumchilds@hotmail.co.uk>; Author <author@noreply.github.com>
Subject: Re: [WordPress/gutenberg] Add a link section for Cover Image Block Settings (#12684)
I know links can often eat semantics when used improperly,
Yep, it really depends on what's inside the linked block. Expanding my previous comment: what if inside the block there's, say, an input field, or a button, or any other interactive element? A link should contain only non-interactive elements. The implementation should make sure to avoid nested interactive elements. At a first glance, this appears to be a bit complicated especially with existing content: should the block content be "cleared" of any interactive element when the block gets linked?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#12684 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGBR2AKVXYPSJJDF2CEVZPLSHMPEDANCNFSM4GJDD7VA>.
|
I don't think we can trust users this way 🙂 Valid, semantic, accessible markup should be enforced via code. |
The disable-link-control-on-nested blocks idea sounds very similar to the issue where sometimes we want to disable the block alignment controls for blocks when they are nested inside another block with a layout/style that doesn't support those alignments. Perhaps the solution to both problems is the same... but I'm not sure what that solution is. |
I might need some guidance on this one. |
Hi Chandrika @cguntur After you get a bit going you can then ask questions that arise directly in the core-editor Slack channel, and let people know that are you are new and working on figuring out ...... |
@paaljoachim Ok, I will give it a try. Thank you for the help. |
Not that I disagree with the intent of preventing invalid markup, but this feature sounds like a bit of a minefield in terms of implementation. Any feature would have to handle various situations:
I also think it's going to be hard to relay to the user what the problem is that's preventing the addition of links. Feels like this particular problem needs some design input more than anything, so I'll apply that label. |
Hej! Any chance to have this useful feature as a core functionality? |
Any updates on this? This should really be added at this point. We need to be able to link rows, columns, groups and cover blocks. |
We definitely need this soon! |
+1 ✨ |
There is a related conversation (but discussing the columns block) on this issue #45959 |
+1 for this, please ! |
+1!!! |
Any updates on this? Cover and Group/Row/Column blocks should have an option to link. |
+1 here |
Chatted with a user recently who wanted the Cover block to work as a link when added inside the Query Loop block. When added inside the Query Loop, we can use the Featured image as the cover image, but it would be awesome to have that image clickable too. |
I'd love to see this implemented though I understand the limitations. Most of the use-cases I have needed this for involve Image blocks that would normally be a link but then I wanted to add text over the image and it turns it into a Cover block. Then only the text can be linked at that point and the rest of the click area of the cover image can't be used. |
Any updates on this "add link functionality to Cover block"? |
I'd love to see this implemented. |
Hi passatgt! Thanks for this idea. I just tried it and don't have the Styles section set-up like in your image. I pasted the code in my Child theme's Function.php. It is my first time editing that file...is there a specific place I am supposed to paste? |
Might be a theme compatibility issue? I tried it with the default twentytwenty-three theme and works fine in the functions.php. |
Similar request from WordPress.com customers as well. |
+1 |
1 similar comment
+1 |
|
+1 |
1 similar comment
+1 |
How has this not been implemented into core yet? I thought I had this problem licked adding an image with a text overlay just to find it converts my block to a cover image which does not allow the image to be clickable. Please add this seemingly basic function to core. |
|
+1. It has been said before, but the cover block is useful in a query loop to show featured images with titles etc. It's a very common pattern for the thumbnail(featured image) to be clickable. |
Is your feature request related to a problem? Please describe.
I want to link a cover image block to a particular page, which I can't do without delving into the code.
Describe the solution you'd like
A "Link" section in the Block settings sidebar (see below)
Describe alternatives you've considered
For now, I will use HTML to link it to the page I want. But most people using this new editor have probably never heard of HTML, let alone coded in it.
(Edit: I've just tried to do this and it says that the block contains "unexpected content" - see below:)
This is the code I entered:
The text was updated successfully, but these errors were encountered: